Fix the windows implementation of KillProcess and WaitForSingleProcess to not...

base/process_util_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _CRT_SECURE_NO_WARNINGS
 
 #include "base/multiprocess_test.h"
 #include "base/platform_thread.h"
 #include "base/process_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 16 matching lines @@
 
 MULTIPROCESS_TEST_MAIN(SimpleChildProcess) {
   return 0;
 }
 
 TEST_F(ProcessUtilTest, SpawnChild) {
   ProcessHandle handle = this->SpawnChild(L"SimpleChildProcess");
 
   ASSERT_NE(static_cast<ProcessHandle>(NULL), handle);
   EXPECT_TRUE(WaitForSingleProcess(handle, 5000));
+  base::CloseProcessHandle(handle);
 }
 
 MULTIPROCESS_TEST_MAIN(SlowChildProcess) {
   // Sleep until file "SlowChildProcess.die" is created.
   FILE *fp;
   do {
     PlatformThread::Sleep(100);
     fp = fopen("SlowChildProcess.die", "r");
   } while (!fp);
   fclose(fp);
@@ skipping 11 matching lines @@
 TEST_F(ProcessUtilTest, KillSlowChild) {
   remove("SlowChildProcess.die");
   int oldcount = GetProcessCount(L"base_unittests" EXE_SUFFIX, 0);
   ProcessHandle handle = this->SpawnChild(L"SlowChildProcess");
   ASSERT_NE(static_cast<ProcessHandle>(NULL), handle);
   EXPECT_EQ(oldcount+1, GetProcessCount(L"base_unittests" EXE_SUFFIX, 0));
   FILE *fp = fopen("SlowChildProcess.die", "w");
   fclose(fp);
   EXPECT_TRUE(base::WaitForSingleProcess(handle, 5000));
   EXPECT_EQ(oldcount, GetProcessCount(L"base_unittests" EXE_SUFFIX, 0));
+  base::CloseProcessHandle(handle);
 }
 
 // TODO(estade): if possible, port these 2 tests.
 #if defined(OS_WIN)
 TEST_F(ProcessUtilTest, EnableLFH) {
   ASSERT_TRUE(EnableLowFragmentationHeap());
   if (IsDebuggerPresent()) {
     // Under these conditions, LFH can't be enabled. There's no point to test
     // anything.
     const char* no_debug_env = getenv("_NO_DEBUG_HEAP");
@@ skipping 131 matching lines @@
   // Read number of open files in client process from pipe;
   int num_open_files = -1;
   ssize_t bytes_read = read(pipe_read_fd, &num_open_files,
                             sizeof(num_open_files));
   ASSERT_EQ(bytes_read, static_cast<ssize_t>(sizeof(num_open_files)));
 
   // Make sure 0 fds are leaked to the client.
   ASSERT_EQ(0, num_open_files);
 
   EXPECT_TRUE(WaitForSingleProcess(handle, 1000));
+  base::CloseProcessHandle(handle);
   close(fds[0]);
   close(sockets[0]);
   close(sockets[1]);
   close(dev_null);
 }
 
 #endif  // defined(OS_POSIX)
 
 }  // namespace base