Quiet down stateful_update & add timeout for downloads.

src/platform/dev/autoupdate.py

 # Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildutil import BuildObject
 from xml.dom import minidom
 
 import os
 import shutil
 import sys
 import web
 
 class Autoupdate(BuildObject):
   # Basic functionality of handling ChromeOS autoupdate pings
   # and building/serving update images.
   # TODO(rtc): Clean this code up and write some tests.
 
   def __init__(self, serve_only=None, test_image=False, urlbase=None,
                factory_config_path=None, validate_factory_config=None,
                *args, **kwargs):
     super(Autoupdate, self).__init__(*args, **kwargs)
     self.serve_only = serve_only
+    self.factory_config = factory_config_path
     self.test_image = test_image
     self.static_urlbase = urlbase
     if serve_only:
       # If  we're  serving  out  of  an archived  build  dir  (e.g.  a
       # buildbot), prepare this webserver's magic 'static/' dir with a
       # link to the build archive.
       web.debug('Autoupdate in "serve update images only" mode.')
       if os.path.exists('static/archive'):
-        archive_symlink = os.readlink('static/archive')
-        if archive_symlink != self.static_dir:
+        if self.static_dir != os.readlink('static/archive'):
           web.debug('removing stale symlink to %s' % self.static_dir)
           os.unlink('static/archive')
+          os.symlink(self.static_dir, 'static/archive')
       else:
-        os.symlink(self.static_dir, 'static/archive')
-    self.factory_config = None
+         os.symlink(self.static_dir, 'static/archive')
     if factory_config_path is not None:
       self.ImportFactoryConfigFile(factory_config_path, validate_factory_config)
 
   def GetUpdatePayload(self, hash, size, url):
     payload = """<?xml version="1.0" encoding="UTF-8"?>
       <gupdate xmlns="http://www.google.com/update2/response" protocol="2.0">
         <app appid="{%s}" status="ok">
           <ping status="ok"/>
           <updatecheck
             codebase="%s"
@@ skipping 52 matching lines @@
       shutil.move(os.path.join(image_path, 'part_3'), rootfs_file)
       os.system('cd %s && rm part_*' % image_path)
       return True
     return False
 
   def UnpackZip(self, image_path, image_file):
     image = os.path.join(image_path, image_file)
     if os.path.exists(image):
       return True
     else:
-      return os.system('cd %s && unzip -o image.zip %s unpack_partitions.sh' %
+      # -n, never clobber an existing file, in case we get invoked
+      # simultaneously by multiple request handlers. This means that
+      # we're assuming each image.zip file lives in a versioned
+      # directory (a la Buildbot).
+      return os.system('cd %s && unzip -n image.zip %s unpack_partitions.sh' %
                        (image_path, image_file)) == 0
 
   def GetImageBinPath(self, image_path):
     if self.test_image:
       image_file = 'chromiumos_test_image.bin'
     else:
       image_file = 'chromiumos_image.bin'
     return image_file
 
   def BuildUpdateImage(self, image_path):
@@ skipping 210 matching lines @@
       ok = self.BuildUpdateImage(latest_image_path)
       if ok != True:
         web.debug('Failed to build an update image')
         return self.GetNoUpdatePayload()
 
       hash = self.GetHash('%s/update.gz' % self.static_dir)
       size = self.GetSize('%s/update.gz' % self.static_dir)
 
       url = 'http://%s/static/update.gz' % hostname
       return self.GetUpdatePayload(hash, size, url)