Issue 239006: [chromium-reviews] Updated comment in tab_switching.cc to replect that Tab-switching test in bui...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239006: [chromium-reviews] Updated comment in tab_switching.cc to replect that Tab-switching test in bui... (Closed)

Created:
11 years, 3 months ago by sidchat (Google)

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews_googlegroups.com, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Updated comment in tab_switching.cc to replect that Tab-switching test in buildbot was outputting 0 because it was missing command line flag -log-level=0. log-level decides the amount of output in the log file, and histograms come under log-level 0. The default was 1, which meant that histograms were not logged - hence the results always showed 0. BUG=www.crbug.com/22965 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27150

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/tab_switching/tab_switching_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages