Issue 2389004: Only inject content scripts into HTML documents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2389004: Only inject content scripts into HTML documents (Closed)

Created:
10 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Only inject content scripts into HTML documents. Previously we would inject into SVG and raw XML documents as well. Injecting into SVG could conceivably be a feature, but I expect it would count as a "bug" more often than that, so I'm starting conservative. BUG=39845 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48693

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	chrome/renderer/user_script_slave.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages