Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 238004: Add an additional unit-test for when PAC script is missing newline.... (Closed)

Created:
11 years, 3 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, darin (slow to review), tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Add an additional unit-test for when PAC script is missing newline. This variation uses a statement without semi-colon, rather than a comment, as the last line. BUG=http://crbug.com/22864 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27171

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address wtc's comments #

Patch Set 3 : reword a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
A net/data/proxy_resolver_v8_unittest/ends_with_statement_no_semicolon.js View Binary file 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 2 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
11 years, 3 months ago (2009-09-24 19:54:05 UTC) #1
eroman
The contents of JS file don't show up in this review, because I marked it ...
11 years, 3 months ago (2009-09-24 19:54:43 UTC) #2
wtc
LGTM. http://codereview.chromium.org/238004/diff/1/2 File net/proxy/proxy_resolver_v8_unittest.cc (right): http://codereview.chromium.org/238004/diff/1/2#newcode425 Line 425: // that we add to the script. ...
11 years, 3 months ago (2009-09-24 20:43:36 UTC) #3
eroman
11 years, 3 months ago (2009-09-24 20:51:41 UTC) #4
http://codereview.chromium.org/238004/diff/1/2
File net/proxy/proxy_resolver_v8_unittest.cc (right):

http://codereview.chromium.org/238004/diff/1/2#newcode425
Line 425: // that we add to the script. http://crbug.com/22864
On 2009/09/24 20:43:36, wtc wrote:
> Nit: "that we add to the script" is no longer true in the
> new code, because now we run the two scripts separately.

Reworded "add to the script" --> "add to the script's environment".

> 
> Why don't we break this into two scripts?  They only share
> one line of code (line 427).

Done, made as 2 separate TESTs.

Powered by Google App Engine
This is Rietveld 408576698