Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 238003: GTK: Use "Set to Classic theme" instead of reset in the options dialog. (Closed)

Created:
11 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
tony, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

GTK: Use "Set to Classic theme" instead of reset in the options dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27118

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Separated this out of the other change.
11 years, 3 months ago (2009-09-24 19:27:16 UTC) #1
Evan Stade
11 years, 3 months ago (2009-09-24 20:25:12 UTC) #2
lgtm

http://codereview.chromium.org/238003/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/238003/diff/1/2#newcode3800
Line 3800: <message name="IDS_THEMES_SET_CLASSIC" desc="The button to choose the
clas sic windows theme in GTK">
nit: does this say "clas sic"? (hard to tell in rietveld)

Powered by Google App Engine
This is Rietveld 408576698