Fix FTP directory listings for servers which use \n as the line break.

Fix FTP directory listings for servers which use \n as the line break.

The previous version of the code assumed that \r\n (CRLF) will always be used.

The FTP spec is extremely imprecise about the LISTing format.

TEST=See bug.
BUG=22879
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27128

[wtc, 2009-09-24 17:56:45]

LGTM.

It's common in networking code to be strict in what we
produce and be lenient in what we accept:
http://en.wikipedia.org/wiki/Robustness_principle

http://codereview.chromium.org/238001/diff/1/2
File webkit/glue/ftp_directory_listing_response_delegate.cc (right):

http://codereview.chromium.org/238001/diff/1/2#newcode68
Line 68: std::string line(buffer->substr(cut_pos, i - cut_pos));
You should be able to avoid the second substr call.

  size_t line_len = i - cut_pos;
  if (line_len && (*buffer)[i - 1] == '\r')
    line_len--;
  lines->push_back(buffer->substr(cut_pos, line_len));
  cut_pos = i + 1;

[Paweł Hajdan Jr., 2009-09-24 20:56:04]

Patch updated. I'm going to commit it when the tree re-opens.

[wtc, 2009-09-25 15:30:04]

One note about the robust principle: an exception to that
rule is security.  A recent example is:
http://www.imc.org/ietf-openpgp/mail-archive/msg14307.html
where some implementations of RSA digital signature
verifiers ignored "junk" bytes after they found the data
they were looking for.