Fix gclient revinfo

Fix gclient revinfo

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48489

[M-A Ruel, 2010-05-28 15:47:36]

no smoke test? :D

lgtm

[Nasser Grainawi, 2010-05-28 15:48:07]

Without this you get some nasty stack traces in the chromium tree.

Traceback (most recent call last):
  File "/local/mnt/workspace/buildbot/revinfo/depot_tools/gclient.py", line
1120, in <module>
    sys.exit(Main(sys.argv[1:]))
  File "/local/mnt/workspace/buildbot/revinfo/depot_tools/gclient.py", line
1112, in Main
    return command(parser, argv[1:])
  File "/local/mnt/workspace/buildbot/revinfo/depot_tools/gclient.py", line
1048, in CMDrevinfo
    client.PrintRevInfo()
  File "/local/mnt/workspace/buildbot/revinfo/depot_tools/gclient.py", line 751,
in PrintRevInfo
    deps = self._ParseAllDeps(entries, entries_deps_content)
  File "/local/mnt/workspace/buildbot/revinfo/depot_tools/gclient.py", line 400,
in _ParseAllDeps
    True)
  File "/local/mnt/workspace/buildbot/revinfo/depot_tools/gclient.py", line 341,
in _ParseSolutionDeps
    if self._options.deps_os is not None:
AttributeError: Values instance has no attribute 'deps_os'

[M-A Ruel, 2010-05-28 15:53:13]

Actually, it's fixed in http://codereview.chromium.org/2238004/show in a better
way, please don't commit this patch and review the other one.

[Nasser Grainawi, 2010-05-28 15:58:32]

maruel@chromium.org wrote:
> Actually, it's fixed in http://codereview.chromium.org/2238004/show in a 
> better
> way, please don't commit this patch and review the other one.
> 
> http://codereview.chromium.org/2380001/show

I don't think 2238004 actually fixes it. You don't add an option to 
CMDrevinfo and I don't think one is appropriate (unless I don't 
understand the python-fu going on here, which is more than likely).

[M-A Ruel, 2010-05-28 16:02:51]

On 2010/05/28 15:58:32, Nasser Grainawi wrote:
> mailto:maruel@chromium.org wrote:
> > Actually, it's fixed in http://codereview.chromium.org/2238004/show in a 
> > better
> > way, please don't commit this patch and review the other one.
> > 
> > http://codereview.chromium.org/2380001/show
> 
> I don't think 2238004 actually fixes it. You don't add an option to 
> CMDrevinfo and I don't think one is appropriate (unless I don't 
> understand the python-fu going on here, which is more than likely).

Oops you're right, I forgot it. I still prefer you to add an option like I've
done in the other review, it at least help with testability.