Issue 2377002: In some circumstances the O3D plugin is briefly resized to zero height,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2377002: In some circumstances the O3D plugin is briefly resized to zero height,... (Closed)

Created:
10 years, 7 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
greggman

CC:
o3d-review_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/o3d/

Visibility:
Public.

Description

In some circumstances the O3D plugin is briefly resized to zero height, causing the Core Graphics rendering backend to request a zero-height render target. base::bits::Log2Ceiling returns -1 for a zero input which was being translated to a huge unsigned integer value, leading to an assertion failure. Verified with submitter's use case. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48507

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/cross/image_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages