Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2372001: Add --subkey_in option to kernel signing utility. (Closed)

Created:
10 years, 7 months ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@gitrw.chromium.org/chromiumos
Visibility:
Public.

Description

Add --subkey_in option to kernel signing utility. This allows for using an existing key signature (subkey) header to generate new signed images if the kernel signing is unchanged. This obviates the need to take out the firmware private key each time a new signed kernel image is generated. A similar change will also be propagated to the firmware signing utility. We would REALLY like to reduce the need to take out the verified boot private root key (used for generating R/W firmware key signature headers) everytime we generate a new signed R/W firmware image.

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -51 lines) Patch
M src/platform/vboot_reference/utility/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform/vboot_reference/utility/include/kernel_utility.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/platform/vboot_reference/utility/kernel_utility.cc View 9 chunks +146 lines, -48 lines 0 comments Download
M src/platform/vboot_reference/vkernel/kernel_image.c View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gauravsh
10 years, 7 months ago (2010-05-28 12:48:02 UTC) #1
Bill Richardson
LGTM
10 years, 7 months ago (2010-05-28 14:47:35 UTC) #2
Randall Spangler
10 years, 7 months ago (2010-05-28 15:58:21 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698