Issue 2366004: Add --subkey_in and --subkey_out options to firmware signing utility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2366004: Add --subkey_in and --subkey_out options to firmware signing utility. (Closed)

Created:
10 years, 6 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org/chromiumos

Visibility:
Public.

Description

Add --subkey_in and --subkey_out options to firmware signing utility. With this change, just like the kernel signing utility, the firmware signing utility now supports outputting the key signature (subkey) header and reusing it to generate new signed firmware images without requiring the root key (assuming the firmware signing key doesn't change). Also, some minor comment fixes I missed the last time around.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -76 lines)			Patch
M	src/platform/vboot_reference/utility/firmware_utility.cc	View	12 chunks	+155 lines, -57 lines	0 comments	Download
M	src/platform/vboot_reference/utility/include/firmware_utility.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/platform/vboot_reference/utility/kernel_utility.cc	View	8 chunks	+13 lines, -11 lines	0 comments	Download
M	src/platform/vboot_reference/vfirmware/firmware_image.c	View	2 chunks	+23 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/vfirmware/include/firmware_image.h	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/platform/vboot_reference/vkernel/include/kernel_image.h	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages