Added change to include creating a pdf file.

Added change to include creating a pdf file.


Added CreateDocs.py so that html docs will be created when this script runs.

[petkov, 2010-05-28 21:03:33]

http://codereview.chromium.org/2366003/diff/7001/8001
File src/scripts/archive_hwqual (right):

http://codereview.chromium.org/2366003/diff/7001/8001#newcode48
src/scripts/archive_hwqual:48:
docgen_dir="${script_dir}/../third_party/autotest/files/utils/docgen"
Could you set docgen_dir to "autotest/files/utils/docgen" instead? And cleanup
after you're done?

[kdlucas, 2010-06-01 18:41:18]

I made changes to support running it from the $TMP location, and it also cleans
up after it runs. This requires a few changes to CreateDocs which is in a
separate CL.

[petkov, 2010-06-02 04:13:21]

http://codereview.chromium.org/2366003/diff/11001/12001
File src/scripts/archive_hwqual (right):

http://codereview.chromium.org/2366003/diff/11001/12001#newcode62
src/scripts/archive_hwqual:62: # Create HTML and PDF test documentation for
HWQual Tests.
Do you want to add an echo "Generating test documentation..."?

http://codereview.chromium.org/2366003/diff/11001/12001#newcode66
src/scripts/archive_hwqual:66: make pdf
nit: instead of cd latex; make; cd ..; you could just

make -C latex pdf

and then
mv latex/refman.pdf "${html_target}/HWQual.pdf"

http://codereview.chromium.org/2366003/diff/11001/12001#newcode67
src/scripts/archive_hwqual:67: cp "refman.pdf" "${html_target}/HWQual.pdf"
s/cp/mv/

http://codereview.chromium.org/2366003/diff/11001/12001#newcode70
src/scripts/archive_hwqual:70: rm -rf testsouce latex *.log
typo? "testsouce" ?

[kdlucas, 2010-06-02 19:42:39]

Ok, I think everything is fixed now. Good suggestion using make -C.

http://codereview.chromium.org/2366003/diff/11001/12001
File src/scripts/archive_hwqual (right):

http://codereview.chromium.org/2366003/diff/11001/12001#newcode62
src/scripts/archive_hwqual:62: # Create HTML and PDF test documentation for
HWQual Tests.
On 2010/06/02 04:13:21, petkov wrote:
> Do you want to add an echo "Generating test documentation..."?
> 

Done.

http://codereview.chromium.org/2366003/diff/11001/12001#newcode66
src/scripts/archive_hwqual:66: make pdf
On 2010/06/02 04:13:21, petkov wrote:
> nit: instead of cd latex; make; cd ..; you could just
> 
> make -C latex pdf
> 
> and then
> mv latex/refman.pdf "${html_target}/HWQual.pdf"
> 

Done.

http://codereview.chromium.org/2366003/diff/11001/12001#newcode67
src/scripts/archive_hwqual:67: cp "refman.pdf" "${html_target}/HWQual.pdf"
On 2010/06/02 04:13:21, petkov wrote:
> s/cp/mv/
> 

Done.

http://codereview.chromium.org/2366003/diff/11001/12001#newcode70
src/scripts/archive_hwqual:70: rm -rf testsouce latex *.log
On 2010/06/02 04:13:21, petkov wrote:
> typo? "testsouce" ?
> 

Done.

[petkov, 2010-06-02 19:52:09]

LGTM w/ a nit.

http://codereview.chromium.org/2366003/diff/16001/17001
File src/scripts/archive_hwqual (right):

http://codereview.chromium.org/2366003/diff/16001/17001#newcode62
src/scripts/archive_hwqual:62: # Create HTML and PDF test documentation for
HWQual Tests.
Add an empty line before this one.