Issue 2365001: X64: Fix issue 678. Bug in some Win64 C calls from generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2365001: X64: Fix issue 678. Bug in some Win64 C calls from generated code. (Closed)

Created:
10 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

X64: Fix issue 678. Bug in some Win64 C calls from generated code. Win 64 C call ABI implementation requires space allocated on stack for four argument registers, even when passing fewer arguments in registers.

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	src/x64/macro-assembler-x64.cc	View		1 chunk	+13 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

10 years, 7 months ago (2010-05-28 08:20:01 UTC) #2

LGTM

http://codereview.chromium.org/2365001/diff/1/2
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/2365001/diff/1/2#newcode2647
src/x64/macro-assembler-x64.cc:2647: // including the ones passed in registers,
and space is alwaysallocated for
always->allocated -> always allocated

Expand Messages | Collapse Messages