Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2363003: Rework the logging for sockets/connectjobs.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/proxy/proxy_script_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
===================================================================
--- net/http/http_network_transaction_unittest.cc (revision 48758)
+++ net/http/http_network_transaction_unittest.cc (working copy)
@@ -114,7 +114,8 @@
&session_deps->socket_factory,
session_deps->ssl_config_service,
session_deps->spdy_session_pool,
- session_deps->http_auth_handler_factory.get());
+ session_deps->http_auth_handler_factory.get(),
+ NULL);
}
class HttpNetworkTransactionTest : public PlatformTest {
@@ -237,9 +238,9 @@
template<typename EmulatedClientSocketPool>
class CaptureGroupNameSocketPool : public EmulatedClientSocketPool {
public:
- CaptureGroupNameSocketPool(HttpNetworkSession* session)
+ explicit CaptureGroupNameSocketPool(HttpNetworkSession* session)
: EmulatedClientSocketPool(0, 0, NULL, session->host_resolver(), NULL,
- NULL) {}
+ NULL, NULL) {}
const std::string last_group_name_received() const {
return last_group_name_;
}
@@ -5589,7 +5590,7 @@
class TLSDecompressionFailureSocketDataProvider : public SocketDataProvider {
public:
- TLSDecompressionFailureSocketDataProvider(bool fail_all)
+ explicit TLSDecompressionFailureSocketDataProvider(bool fail_all)
: fail_all_(fail_all) {
}
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/proxy/proxy_script_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698