Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: net/socket/ssl_client_socket_unittest.cc

Issue 2363003: Rework the logging for sockets/connectjobs.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/ssl_client_socket.h" 5 #include "net/socket/ssl_client_socket.h"
6 6
7 #include "net/base/address_list.h" 7 #include "net/base/address_list.h"
8 #include "net/base/host_resolver.h" 8 #include "net/base/host_resolver.h"
9 #include "net/base/io_buffer.h" 9 #include "net/base/io_buffer.h"
10 #include "net/base/net_log.h" 10 #include "net/base/net_log.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 EXPECT_EQ(net::OK, rv); 77 EXPECT_EQ(net::OK, rv);
78 78
79 scoped_ptr<net::SSLClientSocket> sock( 79 scoped_ptr<net::SSLClientSocket> sock(
80 socket_factory_->CreateSSLClientSocket(transport, 80 socket_factory_->CreateSSLClientSocket(transport,
81 server_.kHostName, kDefaultSSLConfig)); 81 server_.kHostName, kDefaultSSLConfig));
82 82
83 EXPECT_FALSE(sock->IsConnected()); 83 EXPECT_FALSE(sock->IsConnected());
84 84
85 rv = sock->Connect(&callback); 85 rv = sock->Connect(&callback);
86 EXPECT_TRUE(net::LogContainsBeginEvent( 86 EXPECT_TRUE(net::LogContainsBeginEvent(
87 log.entries(), 4, net::NetLog::TYPE_SSL_CONNECT)); 87 log.entries(), 5, net::NetLog::TYPE_SSL_CONNECT));
88 if (rv != net::OK) { 88 if (rv != net::OK) {
89 ASSERT_EQ(net::ERR_IO_PENDING, rv); 89 ASSERT_EQ(net::ERR_IO_PENDING, rv);
90 EXPECT_FALSE(sock->IsConnected()); 90 EXPECT_FALSE(sock->IsConnected());
91 EXPECT_FALSE(net::LogContainsEndEvent( 91 EXPECT_FALSE(net::LogContainsEndEvent(
92 log.entries(), -1, net::NetLog::TYPE_SSL_CONNECT)); 92 log.entries(), -1, net::NetLog::TYPE_SSL_CONNECT));
93 93
94 rv = callback.WaitForResult(); 94 rv = callback.WaitForResult();
95 EXPECT_EQ(net::OK, rv); 95 EXPECT_EQ(net::OK, rv);
96 } 96 }
97 97
(...skipping 23 matching lines...) Expand all
121 EXPECT_EQ(net::OK, rv); 121 EXPECT_EQ(net::OK, rv);
122 122
123 scoped_ptr<net::SSLClientSocket> sock( 123 scoped_ptr<net::SSLClientSocket> sock(
124 socket_factory_->CreateSSLClientSocket(transport, 124 socket_factory_->CreateSSLClientSocket(transport,
125 server_.kHostName, kDefaultSSLConfig)); 125 server_.kHostName, kDefaultSSLConfig));
126 126
127 EXPECT_FALSE(sock->IsConnected()); 127 EXPECT_FALSE(sock->IsConnected());
128 128
129 rv = sock->Connect(&callback); 129 rv = sock->Connect(&callback);
130 EXPECT_TRUE(net::LogContainsBeginEvent( 130 EXPECT_TRUE(net::LogContainsBeginEvent(
131 log.entries(), 4, net::NetLog::TYPE_SSL_CONNECT)); 131 log.entries(), 5, net::NetLog::TYPE_SSL_CONNECT));
132 if (rv != net::OK) { 132 if (rv != net::OK) {
133 ASSERT_EQ(net::ERR_IO_PENDING, rv); 133 ASSERT_EQ(net::ERR_IO_PENDING, rv);
134 EXPECT_FALSE(sock->IsConnected()); 134 EXPECT_FALSE(sock->IsConnected());
135 EXPECT_FALSE(net::LogContainsEndEvent( 135 EXPECT_FALSE(net::LogContainsEndEvent(
136 log.entries(), -1, net::NetLog::TYPE_SSL_CONNECT)); 136 log.entries(), -1, net::NetLog::TYPE_SSL_CONNECT));
137 137
138 rv = callback.WaitForResult(); 138 rv = callback.WaitForResult();
139 EXPECT_EQ(net::ERR_CERT_DATE_INVALID, rv); 139 EXPECT_EQ(net::ERR_CERT_DATE_INVALID, rv);
140 } 140 }
141 141
(...skipping 25 matching lines...) Expand all
167 167
168 scoped_ptr<net::SSLClientSocket> sock( 168 scoped_ptr<net::SSLClientSocket> sock(
169 socket_factory_->CreateSSLClientSocket(transport, 169 socket_factory_->CreateSSLClientSocket(transport,
170 server_.kMismatchedHostName, kDefaultSSLConfig)); 170 server_.kMismatchedHostName, kDefaultSSLConfig));
171 171
172 EXPECT_FALSE(sock->IsConnected()); 172 EXPECT_FALSE(sock->IsConnected());
173 173
174 rv = sock->Connect(&callback); 174 rv = sock->Connect(&callback);
175 175
176 EXPECT_TRUE(net::LogContainsBeginEvent( 176 EXPECT_TRUE(net::LogContainsBeginEvent(
177 log.entries(), 4, net::NetLog::TYPE_SSL_CONNECT)); 177 log.entries(), 5, net::NetLog::TYPE_SSL_CONNECT));
178 if (rv != net::ERR_CERT_COMMON_NAME_INVALID) { 178 if (rv != net::ERR_CERT_COMMON_NAME_INVALID) {
179 ASSERT_EQ(net::ERR_IO_PENDING, rv); 179 ASSERT_EQ(net::ERR_IO_PENDING, rv);
180 EXPECT_FALSE(sock->IsConnected()); 180 EXPECT_FALSE(sock->IsConnected());
181 EXPECT_FALSE(net::LogContainsEndEvent( 181 EXPECT_FALSE(net::LogContainsEndEvent(
182 log.entries(), -1, net::NetLog::TYPE_SSL_CONNECT)); 182 log.entries(), -1, net::NetLog::TYPE_SSL_CONNECT));
183 183
184 rv = callback.WaitForResult(); 184 rv = callback.WaitForResult();
185 EXPECT_EQ(net::ERR_CERT_COMMON_NAME_INVALID, rv); 185 EXPECT_EQ(net::ERR_CERT_COMMON_NAME_INVALID, rv);
186 } 186 }
187 187
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 rv = callback.WaitForResult(); 462 rv = callback.WaitForResult();
463 EXPECT_EQ(net::OK, rv); 463 EXPECT_EQ(net::OK, rv);
464 464
465 scoped_ptr<net::SSLClientSocket> sock( 465 scoped_ptr<net::SSLClientSocket> sock(
466 socket_factory_->CreateSSLClientSocket( 466 socket_factory_->CreateSSLClientSocket(
467 transport, server_.kHostName, kDefaultSSLConfig)); 467 transport, server_.kHostName, kDefaultSSLConfig));
468 468
469 rv = sock->Connect(&callback); 469 rv = sock->Connect(&callback);
470 EXPECT_EQ(net::ERR_SSL_PROTOCOL_ERROR, rv); 470 EXPECT_EQ(net::ERR_SSL_PROTOCOL_ERROR, rv);
471 } 471 }
OLDNEW
« no previous file with comments | « net/socket/socks_client_socket_pool_unittest.cc ('k') | net/socket/tcp_client_socket_libevent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698