Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2360002: audio use xmmintrin for sse to reduce requirement from sse2 to sse... (Closed)

Created:
10 years, 7 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews, scherkus (not reviewing), awong, Alpha Left Google
Visibility:
Public.

Description

audio use xmmintrin for sse to reduce requirement from sse2 to sse BUG=44643 TEST=build with compiler options that enable sse but disable sse2 and chrome should still build and run on Pentium3. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
fbarchard
downgrading requirement from sse2 to sse by using xmmintrin.h sse (float) on pentium3 uses xmmintrin.h ...
10 years, 7 months ago (2010-05-28 17:22:00 UTC) #1
scherkus (not reviewing)
LGTM are there any gyp changes needed?
10 years, 7 months ago (2010-05-28 19:00:13 UTC) #2
fbarchard
10 years, 7 months ago (2010-05-28 19:39:22 UTC) #3
On 2010/05/28 19:00:13, scherkus wrote:
> LGTM
> 
> are there any gyp changes needed?

no gyp changes needed.

Powered by Google App Engine
This is Rietveld 408576698