Issue 2359002: Simplify Chrome Frame usage of Chrome identifiers by simply using the Chrome ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2359002: Simplify Chrome Frame usage of Chrome identifiers by simply using the Chrome ... (Closed)

Created:
10 years, 7 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews, kuchhal, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Simplify Chrome Frame usage of Chrome identifiers by simply using the Chrome identifiers directly. This required renaming a few identifiers to avoid macro renaming conflicts when including the Chrome headers. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48543

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -43 lines)			Patch
M	chrome_frame/chrome_active_document.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome_frame/chrome_active_document.cc	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome_frame/chrome_imported_resources.h	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
D	chrome_frame/chrome_imported_resources.cc	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome_frame/resources/chrome_frame_resources.grd	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/resources/structured_resources.rc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages