Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c

Issue 2358002: Change to the new prototype/name for Get/WriteStoredVersions(). (Closed) Base URL: ssh://git@gitrw.chromium.org/chromiumos
Patch Set: merge cases Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c
diff --git a/src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c b/src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c
index 8b75180116df2f828a7e1be4357a4d8c73123bba..8ec440b5993eb295769c3d0c859b7185dce79f33 100644
--- a/src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c
+++ b/src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c
@@ -109,9 +109,9 @@ int LoadKernel(LoadKernelParams* params) {
* when the RW firmware is verified. Is it harmful to call SetupTPM()
* again if it's already initialized? It'd be easier if we could just do
* that. */
- tpm_kernel_key_version = GetStoredVersion(KERNEL_KEY_VERSION);
- tpm_kernel_version = GetStoredVersion(KERNEL_VERSION);
-
+ GetStoredVersions(KERNEL_VERSIONS,
+ &tpm_kernel_key_version,
+ &tpm_kernel_version);
do {
/* Read GPT data */
gpt.sector_bytes = blba;
@@ -241,13 +241,12 @@ int LoadKernel(LoadKernelParams* params) {
if (good_partition >= 0) {
/* See if we need to update the TPM */
- if (lowest_kernel_key_version > tpm_kernel_key_version) {
- WriteStoredVersion(KERNEL_KEY_VERSION, lowest_kernel_key_version);
- WriteStoredVersion(KERNEL_VERSION, lowest_kernel_version);
- }
- else if (lowest_kernel_key_version == tpm_kernel_key_version &&
- lowest_kernel_version > tpm_kernel_version) {
- WriteStoredVersion(KERNEL_VERSION, lowest_kernel_version);
+ if ((lowest_kernel_key_version > tpm_kernel_key_version) ||
+ (lowest_kernel_key_version == tpm_kernel_key_version &&
+ lowest_kernel_version > tpm_kernel_version)) {
+ WriteStoredVersions(KERNEL_VERSIONS,
+ lowest_kernel_key_version,
+ lowest_kernel_version);
}
if (BOOT_MODE_RECOVERY != params->boot_mode) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698