Issue 2358002: Change to the new prototype/name for Get/WriteStoredVersions().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2358002: Change to the new prototype/name for Get/WriteStoredVersions(). (Closed)

Created:
10 years, 7 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, Luigi Semenzato

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org/chromiumos

Visibility:
Public.

Description

Change to the new prototype/name for Get/WriteStoredVersions(). This should fix the compilation error after Luigi's latest change went in.

Patch Set 2 : merge cases #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c	View	1	2 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

LGTM, but you may want to make one little improvement. http://codereview.chromium.org/2358002/diff/1/2 File src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c (right): http://codereview.chromium.org/2358002/diff/1/2#newcode253 ...

10 years, 7 months ago (2010-05-28 19:20:05 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 2358002: Change to the new prototype/name for Get/WriteStoredVersions(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : merge cases #

Messages