Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2358002: Change to the new prototype/name for Get/WriteStoredVersions(). (Closed)

Created:
10 years, 7 months ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@gitrw.chromium.org/chromiumos
Visibility:
Public.

Description

Change to the new prototype/name for Get/WriteStoredVersions(). This should fix the compilation error after Luigi's latest change went in.

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c View 1 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gauravsh
10 years, 7 months ago (2010-05-28 18:54:44 UTC) #1
Luigi Semenzato
LGTM, but you may want to make one little improvement. http://codereview.chromium.org/2358002/diff/1/2 File src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c (right): http://codereview.chromium.org/2358002/diff/1/2#newcode253 ...
10 years, 7 months ago (2010-05-28 19:20:05 UTC) #2
Randall Spangler
10 years, 7 months ago (2010-05-28 19:44:42 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698