Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2352002: Make FakeRepos more reusable. Make it work with 'coverage'. (Closed)

Created:
10 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make FakeRepos more reusable. Make it work with 'coverage'. Make FakeRepos initialization lazy. Only generate the repository when needed. It's in part intended for gclient_scm_tests.py but I left it out of this review. To use: easy_install coverage ./tests/gclient_smoke.py -c coverage report Current coverage with gclient_smoke: Name Stmts Exec Cover ----------------------------------------------- gclient 557 416 74% gclient_scm 496 270 54% gclient_utils 195 117 60% scm 439 180 41% (ignoring irrelevant files) It's quite good in fact, 74% of gclient.py being executed with the smoke test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -227 lines) Patch
M gclient.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/fake_repos.py View 12 chunks +182 lines, -57 lines 0 comments Download
M tests/gclient_smoketest.py View 15 chunks +82 lines, -170 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 7 months ago (2010-05-28 02:12:25 UTC) #1
Nasser Grainawi
10 years, 6 months ago (2010-05-28 17:28:42 UTC) #2
'easy_install coverage' failed for me, but that's not your fault :)
lgtm

Powered by Google App Engine
This is Rietveld 408576698