Issue 2352001: render creation require media format have mime type and width/height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2352001: render creation require media format have mime type and width/height (Closed)

Created:
10 years, 7 months ago by jiesun

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews

Visibility:
Public.

renderer filter creation require media format have mime type and width/height. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48519

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -6 lines)			Patch
	M	media/filters/omx_video_decoder.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	media/filters/omx_video_decoder.cc	View		2 chunks	+23 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

jiesun

player_x11 is better on Qcom now. still have other issues.

10 years, 7 months ago (2010-05-28 01:01:14 UTC) #1

Alpha Left Google

10 years, 7 months ago (2010-05-28 01:03:22 UTC) #2

I prefer using int to store width and height, but it's up to you. Otherwise
LGTM.