Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/tab_contents/tab_contents_view_gtk.cc

Issue 235039: Fix conflicts between accelerator keys and HTML DOM accesskeys.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_view_gtk.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents_view_gtk.cc (revision 29767)
+++ chrome/browser/tab_contents/tab_contents_view_gtk.cc (working copy)
@@ -320,14 +320,14 @@
}
}
-void TabContentsViewGtk::HandleKeyboardEvent(
+bool TabContentsViewGtk::HandleKeyboardEvent(
const NativeWebKeyboardEvent& event) {
// This may be an accelerator. Try to pass it on to our browser window
// to handle.
GtkWindow* window = GetTopLevelNativeWindow();
if (!window) {
NOTREACHED();
- return;
+ return false;
}
// Filter out pseudo key events created by GtkIMContext signal handlers.
@@ -339,12 +339,12 @@
// as an accelerator.
if (event.type == WebKit::WebInputEvent::Char ||
event.type == WebKit::WebInputEvent::KeyUp)
- return;
+ return false;
BrowserWindowGtk* browser_window =
BrowserWindowGtk::GetBrowserWindowForNativeWindow(window);
DCHECK(browser_window);
- browser_window->HandleKeyboardEvent(event.os_event);
+ return browser_window->HandleKeyboardEvent(event.os_event);
}
void TabContentsViewGtk::Observe(NotificationType type,

Powered by Google App Engine
This is Rietveld 408576698