Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2611)

Unified Diff: chrome/browser/tab_contents/interstitial_page.cc

Issue 235039: Fix conflicts between accelerator keys and HTML DOM accesskeys.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/interstitial_page.cc
===================================================================
--- chrome/browser/tab_contents/interstitial_page.cc (revision 29767)
+++ chrome/browser/tab_contents/interstitial_page.cc (working copy)
@@ -97,7 +97,7 @@
virtual void GotFocus();
virtual void TakeFocus(bool reverse);
virtual bool IsReservedAccelerator(const NativeWebKeyboardEvent& event);
- virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
+ virtual bool HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
virtual void HandleMouseEvent();
virtual void HandleMouseLeave();
virtual void OnFindReply(int request_id,
@@ -584,10 +584,12 @@
return false;
}
-void InterstitialPage::InterstitialPageRVHViewDelegate::HandleKeyboardEvent(
+bool InterstitialPage::InterstitialPageRVHViewDelegate::HandleKeyboardEvent(
const NativeWebKeyboardEvent& event) {
if (interstitial_page_->tab() && interstitial_page_->tab()->GetViewDelegate())
- interstitial_page_->tab()->GetViewDelegate()->HandleKeyboardEvent(event);
+ return interstitial_page_->tab()->GetViewDelegate()->
+ HandleKeyboardEvent(event);
+ return false;
}
void InterstitialPage::InterstitialPageRVHViewDelegate::HandleMouseEvent() {

Powered by Google App Engine
This is Rietveld 408576698