Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: chrome/browser/login_prompt.cc

Issue 235030: Fix the proxy host and port string to start with http:// if it does not already. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/login_prompt.cc
===================================================================
--- chrome/browser/login_prompt.cc (revision 30012)
+++ chrome/browser/login_prompt.cc (working copy)
@@ -113,7 +113,11 @@
dialog_form.scheme = PasswordForm::SCHEME_OTHER;
}
if (auth_info_->is_proxy) {
- dialog_form.origin = GURL(WideToASCII(auth_info_->host_and_port));
+ std::string origin = WideToASCII(auth_info_->host_and_port);
+ // We don't expect this to already start with http:// or https://.
+ DCHECK(origin.find("http://") != 0 && origin.find("https://") != 0);
+ origin = std::string("http://") + origin;
+ dialog_form.origin = GURL(origin);
} else {
dialog_form.origin = origin_url;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698