Fix the proxy host and port string to start with http:// if it does not already.

Fix the proxy host and port string to start with http:// if it does not already.
BUG=21218
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30018

[eroman, 2009-10-03 01:40:47]

http://codereview.chromium.org/235030/diff/1/2
File chrome/browser/login_prompt.cc (right):

http://codereview.chromium.org/235030/diff/1/2#newcode117
Line 117: if (origin.find("http://") != 0 && origin.find("https://") != 0) {
why are the checks for "http://" and "https://" necessary? doesn't seem they
would ever have that

[Mike Mammarella, 2009-10-03 01:57:28]

On 2009/10/03 01:40:47, eroman wrote:
> http://codereview.chromium.org/235030/diff/1/2
> File chrome/browser/login_prompt.cc (right):
> 
> http://codereview.chromium.org/235030/diff/1/2#newcode117
> Line 117: if (origin.find("http://") != 0 && origin.find("https://") != 0) {
> why are the checks for "http://" and "https://" necessary? doesn't seem they
> would ever have that

Paranoia. :)
But it could be changed to a DCHECK or something instead.

[eroman, 2009-10-03 02:09:57]

> Paranoia. :)
> But it could be changed to a DCHECK or something instead.

I would take those checks out (as that is not the format we expect host_and_port
to be in), but DCHECKs are fine with me.

otherwise LGTM.