Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 235025: Use windows keycodes under linux (and all non-windows platforms). (Closed)

Created:
11 years, 3 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., brettw, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Relanding erg's change with fix for toolkit_views shortcuts and interactive ui tests. Note that this was originally reviewed in http://codereview.chromium.org/217022/show I originally Elliot suggestion of replacing the usage of int for keycode with the bae::Keycode type, but that led to the CL getting out of hands (as this is used in many different places). So this is only the patch set 1 of that CL, I'll replace the type in another CL] Use windows keycodes under linux (and all non-windows platforms). This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this wrong behaviour. Previously, keyboard_codes_linux defined all the VKEY_* constants as their GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve to windows key codes. BUG=22551 TEST=Make sure accelerators still work as expected on Chrome Linux and Chrome Linux with toolkit views. Test when the the accelerators with the focus in the location bar and also with the focus on the page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27284

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+820 lines, -568 lines) Patch
M base/base.gyp View 1 3 chunks +5 lines, -2 lines 0 comments Download
A base/keyboard_code_conversion_gtk.h View 1 chunk +49 lines, -0 lines 0 comments Download
A base/keyboard_code_conversion_gtk.cc View 1 chunk +642 lines, -0 lines 0 comments Download
M base/keyboard_codes.h View 1 chunk +2 lines, -4 lines 0 comments Download
D base/keyboard_codes_linux.h View 1 chunk +0 lines, -214 lines 0 comments Download
D base/keyboard_codes_mac.h View 1 chunk +0 lines, -208 lines 0 comments Download
A + base/keyboard_codes_posix.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/ui_controls.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/automation/ui_controls_linux.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/views/accelerator_table_gtk.h View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/views/accelerator_table_gtk.cc View 1 chunk +88 lines, -110 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/custom_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/event.h View 1 chunk +5 lines, -1 line 0 comments Download
M views/event_gtk.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M views/focus/accelerator_handler_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/widget_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698