Issue 235007: Simplify failure codepaths of MessagePumpLibevent::WatchFileDescriptor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235007: Simplify failure codepaths of MessagePumpLibevent::WatchFileDescriptor() (Closed)

Created:
11 years, 3 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
dkegel, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Simplify failure codepaths of MessagePumpLibevent::WatchFileDescriptor() event_del is now called once if we reuse an event so there's no need to call it multiple times for each failure mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27107

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -21 lines)			Patch
	M	base/message_pump_libevent.cc	View		2 chunks	+8 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ahh, that's much less sucky.  Thank you!
LGTM

Expand Messages | Collapse Messages