AutoFill: Refactor the code used to fill a form. Don't fill autocomplete=off

AutoFill: Refactor the code used to fill a form.  Don't fill autocomplete=off
or non-empty fields.

BUG=45143
TEST=FormManagerTest.FillForm

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48467

[dhollowa, 2010-05-28 02:07:07]

http://codereview.chromium.org/2348001/diff/3001/4002
File chrome/renderer/form_manager.h (right):

http://codereview.chromium.org/2348001/diff/3001/4002#newcode142
chrome/renderer/form_manager.h:142: Callback* callback);
Curious, why the need to parameterize the callback?  I only see the one
callback.  So why not just a direct method call?

http://codereview.chromium.org/2348001/diff/3001/4003
File chrome/renderer/form_manager_unittest.cc (right):

http://codereview.chromium.org/2348001/diff/3001/4003#newcode390
chrome/renderer/form_manager_unittest.cc:390: EXPECT_EQ(FormField(string16(),
These guys need the StrictlyEqualsHack() too I think.

[James Hawkins, 2010-05-28 02:17:27]

http://codereview.chromium.org/2348001/diff/3001/4002
File chrome/renderer/form_manager.h (right):

http://codereview.chromium.org/2348001/diff/3001/4002#newcode142
chrome/renderer/form_manager.h:142: Callback* callback);
On 2010/05/28 02:07:07, dhollowa wrote:
> Curious, why the need to parameterize the callback?  I only see the one
> callback.  So why not just a direct method call?

You seem to have forgotten the CL this code came from, where there is also
PreviewForm :-)

http://codereview.chromium.org/2348001/diff/3001/4003
File chrome/renderer/form_manager_unittest.cc (right):

http://codereview.chromium.org/2348001/diff/3001/4003#newcode390
chrome/renderer/form_manager_unittest.cc:390: EXPECT_EQ(FormField(string16(),
On 2010/05/28 02:07:07, dhollowa wrote:
> These guys need the StrictlyEqualsHack() too I think.

Not particularly, since they have no values at this point.  I only changed the
places where I also hand-checked the value().

[dhollowa, 2010-05-28 02:31:09]

Ok.  Thanks for the reminder.  LGTM.