Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: o3d/gpu_plugin/system_services/shared_memory_unittest.cc

Issue 234001: GPUProcessor uses O3D command buffer service to render to a window.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « o3d/gpu_plugin/system_services/shared_memory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: o3d/gpu_plugin/system_services/shared_memory_unittest.cc
===================================================================
--- o3d/gpu_plugin/system_services/shared_memory_unittest.cc (revision 26879)
+++ o3d/gpu_plugin/system_services/shared_memory_unittest.cc (working copy)
@@ -115,10 +115,10 @@
shared_memory_->Initialize(temp_shared_memory, 65536);
EXPECT_TRUE(shared_memory_->Map());
- EXPECT_TRUE(shared_memory_->SetInt32(4, 7));
+ EXPECT_TRUE(shared_memory_->SetInt32(1, 7));
EXPECT_EQ(7, static_cast<int32*>(shared_memory_->ptr)[1]);
- EXPECT_TRUE(shared_memory_->SetInt32(4, 8));
+ EXPECT_TRUE(shared_memory_->SetInt32(1, 8));
EXPECT_EQ(8, static_cast<int32*>(shared_memory_->ptr)[1]);
}
@@ -128,7 +128,7 @@
shared_memory_->Initialize(temp_shared_memory, 65536);
- EXPECT_FALSE(shared_memory_->SetInt32(4, 7));
+ EXPECT_FALSE(shared_memory_->SetInt32(1, 7));
}
TEST_F(SharedMemoryTest, FailsIfSetInt32OffsetIsOutOfRange) {
@@ -139,18 +139,42 @@
EXPECT_TRUE(shared_memory_->Map());
EXPECT_FALSE(shared_memory_->SetInt32(-1, 7));
- EXPECT_FALSE(shared_memory_->SetInt32(65536, 7));
+ EXPECT_FALSE(shared_memory_->SetInt32(16384, 7));
}
-TEST_F(SharedMemoryTest, FailsIfSetInt32OffsetIsMisaligned) {
+TEST_F(SharedMemoryTest, CanSetFloat) {
base::SharedMemory* temp_shared_memory = new base::SharedMemory;
EXPECT_TRUE(temp_shared_memory->Create(std::wstring(), false, false, 65536));
shared_memory_->Initialize(temp_shared_memory, 65536);
EXPECT_TRUE(shared_memory_->Map());
- EXPECT_FALSE(shared_memory_->SetInt32(1, 7));
+ EXPECT_TRUE(shared_memory_->SetFloat(1, 7));
+ EXPECT_EQ(7, static_cast<float*>(shared_memory_->ptr)[1]);
+
+ EXPECT_TRUE(shared_memory_->SetFloat(1, 8));
+ EXPECT_EQ(8, static_cast<float*>(shared_memory_->ptr)[1]);
}
+TEST_F(SharedMemoryTest, FailsIfSetFloatCalledBeforeMap) {
+ base::SharedMemory* temp_shared_memory = new base::SharedMemory;
+ EXPECT_TRUE(temp_shared_memory->Create(std::wstring(), false, false, 65536));
+
+ shared_memory_->Initialize(temp_shared_memory, 65536);
+
+ EXPECT_FALSE(shared_memory_->SetFloat(1, 7));
+}
+
+TEST_F(SharedMemoryTest, FailsIfSetFloatOffsetIsOutOfRange) {
+ base::SharedMemory* temp_shared_memory = new base::SharedMemory;
+ EXPECT_TRUE(temp_shared_memory->Create(std::wstring(), false, false, 65536));
+
+ shared_memory_->Initialize(temp_shared_memory, 65536);
+ EXPECT_TRUE(shared_memory_->Map());
+
+ EXPECT_FALSE(shared_memory_->SetFloat(-1, 7));
+ EXPECT_FALSE(shared_memory_->SetFloat(16384, 7));
+}
+
} // namespace gpu_plugin
} // namespace o3d
« no previous file with comments | « o3d/gpu_plugin/system_services/shared_memory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698