Add accessible_name property for info bubbles (so far added name to bookmark ...

Add accessible_name property for info bubbles (so far added name to bookmark bubble object which implements WidgetWin).
TEST=none
BUG=9601
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49849

[dmazzoni, 2010-06-01 14:14:57]

LGTM.

http://codereview.chromium.org/2338001/diff/6001/7003
File chrome/browser/views/bookmark_bubble_view.h (right):

http://codereview.chromium.org/2338001/diff/6001/7003#newcode126
chrome/browser/views/bookmark_bubble_view.h:126: virtual std::wstring
accessible_name();
You inadvertantly grouped this with InfoDelegate methods. If this method is
supposed to be public, I'd put it right after set_info_bubble, above.

[dtseng, 2010-06-01 17:42:12]

accessible_name overrides InfoBubbleDelegate's accessible_name, so
that's why I place it there.  I'm not clear on the accessmodifiers
with the nested class definition above, but at runtime, InfoBubble
does have access to the delegate's accessible_name property.

It's a bit confusing I'll admit since the BookmarkBubbleView
implements both the InfoBubbleDelegate interface and inherit from View
(both of which have an accessibility name getter).

On 6/1/10, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
> LGTM.
>
>
>
> http://codereview.chromium.org/2338001/diff/6001/7003
> File chrome/browser/views/bookmark_bubble_view.h (right):
>
> http://codereview.chromium.org/2338001/diff/6001/7003#newcode126
> chrome/browser/views/bookmark_bubble_view.h:126: virtual std::wstring
> accessible_name();
> You inadvertantly grouped this with InfoDelegate methods. If this method
> is supposed to be public, I'd put it right after set_info_bubble, above.
>
> http://codereview.chromium.org/2338001/show
>

[dmazzoni, 2010-06-01 20:17:40]

Oops, you're right. I thought it was the other accessibility name getter.

I'll patch this in and send to trybots now.

- Dominic

On Tue, Jun 1, 2010 at 10:41 AM, David Tseng <dtseng@google.com> wrote:

> accessible_name overrides InfoBubbleDelegate's accessible_name, so
> that's why I place it there.  I'm not clear on the accessmodifiers
> with the nested class definition above, but at runtime, InfoBubble
> does have access to the delegate's accessible_name property.
>
> It's a bit confusing I'll admit since the BookmarkBubbleView
> implements both the InfoBubbleDelegate interface and inherit from View
> (both of which have an accessibility name getter).
>
> On 6/1/10, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
> > LGTM.
> >
> >
> >
> > http://codereview.chromium.org/2338001/diff/6001/7003
> > File chrome/browser/views/bookmark_bubble_view.h (right):
> >
> > http://codereview.chromium.org/2338001/diff/6001/7003#newcode126
> > chrome/browser/views/bookmark_bubble_view.h:126: virtual std::wstring
> > accessible_name();
> > You inadvertantly grouped this with InfoDelegate methods. If this method
> > is supposed to be public, I'd put it right after set_info_bubble, above.
> >
> > http://codereview.chromium.org/2338001/show
> >
>