presubmit_canned_checks.py - Issue 2337003: Ignore case in tree status check - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1373)

My Issues | Starred Open | Closed | All

Unified Diff: presubmit_canned_checks.py

Issue 2337003: Ignore case in tree status check (Closed)

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 901a755ada410dfab7abd7868e37478dc06ad5ac..5b972d63ec171810744457c147fe848f6942aab8 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -350,7 +350,7 @@ def CheckTreeIsOpen(input_api, output_api, url, closed):

connection = input_api.urllib2.urlopen(url)

status = connection.read()

connection.close()

- if input_api.re.match(closed, status):

+ if input_api.re.match(closed, status, input_api.re.IGNORECASE):

long_text = status + '\n' + url

return [output_api.PresubmitError('The tree is closed dude!',

long_text=long_text)]

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698