Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2332004: Fix a regression which caused flash plugin installation to not work via the C... (Closed)

Created:
10 years, 7 months ago by ananta
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Fix a regression which caused flash plugin installation to not work via the Chrome plugin installer. The regression was caused due to the mouse hook proc getting installed assuming that the current plugin was flash and setting and releasing capture thus messing up the button controls capture state causing it to not fire the WM_COMMAND messages for plugin installation and cancellation. Fix is to not install the mouse hook for internal plugins. The other fix is to have the mouse hook be a noop if the underlying window is not our plugin window. Fixes bug http://code.google.com/p/chromium/issues/detail?id=28025 Bug=28025 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 4 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
10 years, 7 months ago (2010-05-28 22:48:36 UTC) #1
darin (slow to review)
LGTM
10 years, 7 months ago (2010-05-28 22:50:44 UTC) #2
jam
10 years, 7 months ago (2010-05-28 23:09:50 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698