Issue 233004: Only generate grit header id values for messages that are

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233004: Only generate grit header id values for messages that are (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Only generate grit header id values for messages that are used. This fixes a bug were we skip numbers in a header file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27087

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	tools/grit/grit/node/message.py	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

TVL

11 years, 3 months ago (2009-09-23 21:37:46 UTC) #2

lg.

given what I just saw on my cl, you might end up needing to clobber a build or
two depending on how the actual windows builds go.