Use SSLClientSocketNSS on Mac OS X. ...

Use SSLClientSocketNSS on Mac OS X. By default, chrome still uses
SSLClientSocketMac. Specify the --use-nss-for-ssl command-line
option to use SSLClientSocketNSS.

The nss.gyp in src/net/third_party/nss is renamed ssl.gyp to avoid
a naming conflict with the nss.gyp in src/third_party/nss. The
GYP generator for Xcode project files disallows same-named .gyp files.

SSL client authentication doesn't work yet.

R=mark
BUG=30689
TEST=No build and test failures on Mac and Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48650

[wtc, 2010-05-28 23:59:05]

Mark,

Please make sure I added the dependencies to the "All" target in
all.gyp correctly.  (I did that based on your suggestion over Chat.)

My changes to net.gyp include some cleanup that isn't required
by this CL.  I combined a standalone "else" condition with an
existing "if" condition in two places.

[Mark Mentovai, 2010-06-01 19:28:37]

LGTM

http://codereview.chromium.org/2322008/diff/19001/20003
File build/all.gyp (right):

http://codereview.chromium.org/2322008/diff/19001/20003#newcode1
build/all.gyp:1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Can you explain (to me) the difference between net/third_party/nss and
third_party/nss?

http://codereview.chromium.org/2322008/diff/19001/20003#newcode22
build/all.gyp:22: '../net/third_party/nss/ssl.gyp:*',
This file now says "net/third_party/nss/ssl.gyp:*" on all platforms (was
formerly Linux/FreeBSD/OpenBSD-only), and "third_party/nss/nss.gyp:*" on Mac and
Windows only (was formerly brought in transitively, apparently).

[wtc, 2010-06-01 22:02:20]

Mark, thanks for the review.

http://codereview.chromium.org/2322008/diff/19001/20003
File build/all.gyp (right):

http://codereview.chromium.org/2322008/diff/19001/20003#newcode1
build/all.gyp:1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
On 2010/06/01 19:28:37, Mark Mentovai wrote:
> Can you explain (to me) the difference between net/third_party/nss and
> third_party/nss?

The README.chromium files in those two directories describe
what each copy of "nss" is.

third_party/nss contains NSPR and base NSS, without the
SSL and S/MIME libraries.

net/third_party/nss contains the SSL library of NSS.

The reason for separating NSS into two pieces
is that we use our own NSS SSL library on all platforms,
whereas we use the system NSPR and base NSS libraries
on Linux/FreeBSD/OpenBSD.  So we only need the source code
for NSPR and base NSS on Mac and Windows.