Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 231014: Add wifi menu button in status bar. (Closed)

Created:
11 years, 3 months ago by Charlie Lee (do not use)
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add wifi menu button to status bar of Chrome OS. Currently showing mock data as we have not hooked it up to ChromeOS shared library wifi code yet. TEST=none BUG=23090 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27269

Patch Set 1 : '' #

Total comments: 14

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -107 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/app/theme/statusbar_disconnected.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_1.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_2.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_3.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_4.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_5.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_6.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_7.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wifi_8.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_wired.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/network_menu_button.h View 1 2 3 1 chunk +116 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/network_menu_button.cc View 1 2 3 4 1 chunk +172 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/password_dialog_view.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/password_dialog_view.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings_contents_view.cc View 1 6 chunks +11 lines, -104 lines 0 comments Download
M chrome/browser/chromeos/status_area_view.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status_area_view.cc View 1 4 chunks +9 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Charlie Lee (do not use)
11 years, 3 months ago (2009-09-25 00:45:09 UTC) #1
sky
Can you also create a bug for this and set BUG= in the description to ...
11 years, 3 months ago (2009-09-25 14:32:13 UTC) #2
Charlie Lee (do not use)
http://codereview.chromium.org/231014/diff/6004/8016 File chrome/browser/chromeos/network_menu_button.cc (right): http://codereview.chromium.org/231014/diff/6004/8016#newcode22 Line 22: network_menu_(this), On 2009/09/25 14:32:14, sky wrote: > you ...
11 years, 3 months ago (2009-09-25 20:29:04 UTC) #3
sky
http://codereview.chromium.org/231014/diff/13004/13019 File chrome/browser/chromeos/network_menu_button.cc (right): http://codereview.chromium.org/231014/diff/13004/13019#newcode120 Line 120: RefreshWifiNetworks(); This should NULL out current_wifi_network_, and probably ...
11 years, 3 months ago (2009-09-25 20:39:52 UTC) #4
Charlie Lee (do not use)
http://codereview.chromium.org/231014/diff/13004/13019 File chrome/browser/chromeos/network_menu_button.cc (right): http://codereview.chromium.org/231014/diff/13004/13019#newcode120 Line 120: RefreshWifiNetworks(); On 2009/09/25 20:39:52, sky wrote: > This ...
11 years, 3 months ago (2009-09-25 21:13:00 UTC) #5
sky
http://codereview.chromium.org/231014/diff/14010/16025 File chrome/browser/chromeos/network_menu_button.cc (right): http://codereview.chromium.org/231014/diff/14010/16025#newcode136 Line 136: wifi_networks_.clear(); Because you're clearing out the wifi_networks_, current_wifi_network_ ...
11 years, 3 months ago (2009-09-25 21:26:50 UTC) #6
Charlie Lee (do not use)
http://codereview.chromium.org/231014/diff/14010/16025 File chrome/browser/chromeos/network_menu_button.cc (right): http://codereview.chromium.org/231014/diff/14010/16025#newcode136 Line 136: wifi_networks_.clear(); On 2009/09/25 21:26:50, sky wrote: > Because ...
11 years, 3 months ago (2009-09-25 21:59:54 UTC) #7
sky
LGTM with the following change. http://codereview.chromium.org/231014/diff/11004/17019 File chrome/browser/chromeos/network_menu_button.cc (right): http://codereview.chromium.org/231014/diff/11004/17019#newcode68 Line 68: if (current_ssid_.empty()) Do ...
11 years, 3 months ago (2009-09-25 22:02:29 UTC) #8
Charlie Lee (do not use)
11 years, 3 months ago (2009-09-25 22:09:27 UTC) #9
Thanks. Please land this for me.

http://codereview.chromium.org/231014/diff/11004/17019
File chrome/browser/chromeos/network_menu_button.cc (right):

http://codereview.chromium.org/231014/diff/11004/17019#newcode68
Line 68: if (current_ssid_.empty())
On 2009/09/25 22:02:30, sky wrote:
> Do you really need the empty check? Isn't that effectively caught by the
string
> comparison?

ah you're right. thanks.

Powered by Google App Engine
This is Rietveld 408576698