Issue 2304002: Add workaround to ignore the first solution specified with --revision solution@rev

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2304002: Add workaround to ignore the first solution specified with --revision solution@rev (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, Nasser Grainawi

CC:
chromium-reviews

Visibility:
Public.

Description

Add workaround to ignore the first solution specified with --revision solution@rev TEST=new smoke test BUG=chromiums-os:3465 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48490

Patch Set 1 #

Patch Set 2 : . #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -79 lines)			Patch
M	gclient.py	View		6 chunks	+45 lines, -45 lines	0 comments	Download
M	tests/fake_repos.py	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/gclient_smoketest.py	View	1	14 chunks	+119 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Warning, once this is committed, the builders behavior will change since they currently always sync ...

10 years, 7 months ago (2010-05-27 02:29:23 UTC) #1

Nasser Grainawi

My only concern is what will happen when either 1787013 or 1652007 get merged. I'm ...

10 years, 7 months ago (2010-05-28 15:06:19 UTC) #3

M-A Ruel

10 years, 7 months ago (2010-05-28 15:50:09 UTC) #4

On 2010/05/28 15:06:19, Nasser Grainawi wrote:
> My only concern is what will happen when either 1787013 or 1652007 get merged.
> I'm hoping to have the latter merged soon since I've been testing it and
haven't
> found any issues.

Blah, frankly, all I can say is that I don't mind. You git folks figure it out.
(You is obviously more that only Nasser).

This bug is a definite p0 so I'll commit right now, it'll probably break the
chromium os builder.

Expand Messages | Collapse Messages