Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2303003: Moved cgptlib into vboot_firmware (Closed)

Created:
10 years, 7 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/chromiumos
Visibility:
Public.

Description

Moved cgptlib into vboot_firmware Moved cgptlib tests into tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, -36 lines) Patch
M src/platform/vboot_reference/Makefile View 1 chunk +2 lines, -3 lines 0 comments Download
D src/platform/vboot_reference/cgptlib/Makefile View 1 chunk +0 lines, -26 lines 0 comments Download
D src/platform/vboot_reference/cgptlib/tests/Makefile View 1 chunk +0 lines, -20 lines 0 comments Download
M src/platform/vboot_reference/tests/Makefile View 3 chunks +5 lines, -0 lines 0 comments Download
A + src/platform/vboot_reference/tests/cgptlib_test.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/tests/cgptlib_test.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/tests/crc32_test.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/tests/crc32_test.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/tests/quick_sort_test.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/tests/quick_sort_test.c View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/platform/vboot_reference/utility/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform/vboot_reference/utility/cgpt/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/vboot_firmware/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/cgptlib.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/crc32.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/cgptlib.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/cgptlib_internal.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/crc32.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/gpt.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/quick_sort.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cgptlib/quick_sort.c View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
10 years, 7 months ago (2010-05-27 01:34:07 UTC) #1
Bill Richardson
10 years, 7 months ago (2010-05-27 03:49:48 UTC) #2 
LGTM. Would you update vboot_firmware/linktest/main.c to ensure that all the
exported symbols are available?

Powered by Google App Engine
This is Rietveld 408576698