Issue 23005: Make mock_render_process_host, test_web_contents, and testing_profile compile...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23005: Make mock_render_process_host, test_web_contents, and testing_profile compile... (Closed)

Created:
11 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make mock_render_process_host, test_web_contents, and testing_profile compile on POSIX. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9200

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -10 lines)			Patch
M	chrome/browser/renderer_host/test_render_view_host.h	View	2 chunks	+9 lines, -2 lines	1 comment	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/test/unit/unit_tests.scons	View	3 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

11 years, 10 months ago (2009-02-05 01:02:12 UTC) #2

lgtm

http://codereview.chromium.org/23005/diff/1/2
File chrome/browser/renderer_host/test_render_view_host.h (right):

http://codereview.chromium.org/23005/diff/1/2#newcode21
Line 21: #else
#elif defined(OS_POSIX)

Expand Messages | Collapse Messages