Issue 2292001: Make kernel signature a part of the kernel preamble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2292001: Make kernel signature a part of the kernel preamble. (Closed)

Created:
10 years, 7 months ago by gauravsh

Modified:
6 years ago

Reviewers:
Randall Spangler, Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org/chromiumos

Visibility:
Public.

Description

Make kernel signature a part of the kernel preamble. With this change, the kernel signature is a part of the preamble block (and therefore, used during preamble signature verification). BUG=670 TEST=image verification tests still pass. corrected splicing test expectations (and it passes).

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -116 lines)			Patch
M	src/platform/vboot_reference/tests/kernel_splicing_tests.c	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/platform/vboot_reference/tests/test_common.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/tests/test_common.c	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h	View	5 chunks	+14 lines, -19 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/kernel_image_fw.c	View	8 chunks	+34 lines, -46 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/linktest/main.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/vkernel/kernel_image.c	View	9 chunks	+42 lines, -45 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks!

Expand Messages | Collapse Messages