DevTools: added a new test for console evaluation on call frame.

DevTools: added a new test for console evaluation on call frame.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26913

[mnaganov (inactive), 2009-09-23 12:26:18]

LGTM with comments

http://codereview.chromium.org/229002/diff/1/3
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/229002/diff/1/3#newcode525
Line 525: scriptResource =
options[scriptSelect.selectedIndex].representedObject;
I guess the second case is more common so you can drop this one for simplicity.

http://codereview.chromium.org/229002/diff/1/3#newcode648
Line 648: 'Unexpected stack depth on the breakpoint. ' + JSON.stringify(msg));
nit: long line

http://codereview.chromium.org/229002/diff/1/3#newcode652
Line 652: 'e+1',
I suggest it's worth mentioning that 'e' is an argument of 'calculate' function
from the test page.

[apavlov, 2009-09-23 12:29:48]

LGTM

http://codereview.chromium.org/229002/diff/1/3
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/229002/diff/1/3#newcode529
Line 529: if (options[i].text == scriptName) {
should we use "===" whenever possible?

http://codereview.chromium.org/229002/diff/1/3#newcode546
Line 546: scriptResource.url.search(new RegExp(scriptName + '$')) != -1,
You can use just ...search(scriptName + '$') - this will be converted into a
RegExp for you.

[yurys, 2009-09-23 12:34:24]

http://codereview.chromium.org/229002/diff/1/3
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/229002/diff/1/3#newcode525
Line 525: scriptResource =
options[scriptSelect.selectedIndex].representedObject;
On 2009/09/23 12:26:18, Michail Naganov wrote:
> I guess the second case is more common so you can drop this one for
simplicity.

I prefer to check for positive condition result instead of negative one in if
blocks(i.e. == instead of !=, if(expr) instead of if(!expr) etc). So I would
keep current implementation.

http://codereview.chromium.org/229002/diff/1/3#newcode648
Line 648: 'Unexpected stack depth on the breakpoint. ' + JSON.stringify(msg));
On 2009/09/23 12:26:18, Michail Naganov wrote:
> nit: long line

Done.

http://codereview.chromium.org/229002/diff/1/3#newcode652
Line 652: 'e+1',
On 2009/09/23 12:26:18, Michail Naganov wrote:
> I suggest it's worth mentioning that 'e' is an argument of 'calculate'
function
> from the test page.

Done.

[yurys, 2009-09-23 12:41:10]

http://codereview.chromium.org/229002/diff/1/3
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/229002/diff/1/3#newcode525
Line 525: scriptResource =
options[scriptSelect.selectedIndex].representedObject;
On 2009/09/23 12:26:18, Michail Naganov wrote:
> I guess the second case is more common so you can drop this one for
simplicity.

Done.

http://codereview.chromium.org/229002/diff/1/3#newcode529
Line 529: if (options[i].text == scriptName) {
On 2009/09/23 12:29:49, apavlov wrote:
> should we use "===" whenever possible?

Done.

http://codereview.chromium.org/229002/diff/1/3#newcode546
Line 546: scriptResource.url.search(new RegExp(scriptName + '$')) != -1,
On 2009/09/23 12:29:49, apavlov wrote:
> You can use just ...search(scriptName + '$') - this will be converted into a
> RegExp for you.
Done.Thanks.