A script to print the hardware class (e.g., hwqual ID) of the device.

A script to print the hardware class (e.g., hwqual ID) of the device.

This script will be used be Chrome's UMA service to add the "hardwareclass"
field to the XML to be uploaded.

[petkov, 2010-05-26 18:26:07]

Open to and looking for suggestions on:

- Location of the script (both in the sources as well as on the target. I'm
planning to install it under /usr/bin in a separate CL.
- Additional component IDs to include in the class. I'd like to keep the string
short though.

[Sameer Nanda, 2010-05-26 19:25:27]

http://codereview.chromium.org/2289001/diff/3001/4001
File src/platform/metrics/hardware_class (right):

http://codereview.chromium.org/2289001/diff/3001/4001#newcode32
src/platform/metrics/hardware_class:32: 
you will probably want to add cpu family, model and stepping from /proc/cpuinfo
also.  I think this will help uniquely identify all the interesting systems we
have out in the wild currently.

[sosa, 2010-05-26 19:34:58]

/usr/bin and platform/metrics look like good locations.

http://codereview.chromium.org/2289001/diff/3001/4001
File src/platform/metrics/hardware_class (right):

http://codereview.chromium.org/2289001/diff/3001/4001#newcode32
src/platform/metrics/hardware_class:32: 
You also should include w/ ssd or not because some machines have been modified
to have ssd's and will be anomaly's in the data.

On 2010/05/26 19:25:27, sameer wrote:
> you will probably want to add cpu family, model and stepping from
/proc/cpuinfo
> also.  I think this will help uniquely identify all the interesting systems we
> have out in the wild currently.

[petkov, 2010-05-26 21:42:56]

PTAL. I've added CPU info. It seems unlikely we'll see machines with the same
CPU/WiFi different root device (SSD/HDD). Let me know if you disagree.

[Sameer Nanda, 2010-05-26 21:49:56]

LGTM

[sosa, 2010-05-26 22:31:00]

LGTM

On Wed, May 26, 2010 at 2:49 PM,  <snanda@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/2289001/show
>