Issue 2287005: Fix typo in CMDcommit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2287005: Fix typo in CMDcommit. (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews

Visibility:
Public.

Description

Fix typo in CMDcommit. TBR=siggi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48396

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gcl.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

10 years, 7 months ago (2010-05-27 15:45:32 UTC) #2

lgtm, thanks!

On Thu, May 27, 2010 at 11:42 AM, <maruel@chromium.org> wrote:

> Reviewers: Ruðrugis,
>
> Description:
> Fix typo in CMDcommit.
>
> TBR=siggi
>
> Please review this at http://codereview.chromium.org/2287005/show
>
> Affected files:
>  M gcl.py
>
>
> Index: gcl.py
> diff --git a/gcl.py b/gcl.py
> index
>
272e8d64803fba3a346a1e7c875022ac8c65f5a2..66c3389f6acf2e37e02afc6e71d4977a3480bb01
> 100755
> --- a/gcl.py
> +++ b/gcl.py
> @@ -877,7 +877,7 @@ def TryChange(change_info, args, swallow_exception):
>
>  @need_change_and_args
>  @attrs(usage='[--no_presubmit]')
> -def CMDcommit(change_list, args):
> +def CMDcommit(change_info, args):
>   """Commits the changelist to the repository."""
>   if not change_info.GetFiles():
>     print "Nothing to commit, changelist is empty."
>
>
>

Expand Messages | Collapse Messages