Add more smoke test for gclient config and gclient revinfo.

tests/gclient_smoketest.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Smoke tests for gclient.py.
 
 Shell out 'gclient' and run basic conformance tests.
 
 This test assumes GClientSmokeBase.URL_BASE is valid.
@@ skipping 116 matching lines @@
     actual = read_tree(self.root_dir)
     diff = dict_diff(tree, actual)
     if diff:
       logging.debug('Actual %s\n%s' % (self.root_dir, pprint.pformat(actual)))
       logging.debug('Expected\n%s' % pprint.pformat(tree))
       logging.debug('Diff\n%s' % pprint.pformat(diff))
     self.assertEquals(tree, actual)
 
 
 class GClientSmoke(GClientSmokeBase):
-  def testCommands(self):
-    """This test is to make sure no new command was added."""
+  def testHelp(self):
+    """testHelp: make sure no new command was added."""
     result = self.gclient(['help'])
     self.assertEquals(1197, len(result[0]))
     self.assertEquals(0, len(result[1]))
     self.assertEquals(0, result[2])
 
+  def testUnknown(self):
+    result = self.gclient(['foo'])
+    self.assertEquals(1197, len(result[0]))
+    self.assertEquals(0, len(result[1]))
+    self.assertEquals(0, result[2])
+
   def testNotConfigured(self):
     res = ('', 'Error: client not configured; see \'gclient config\'\n', 1)
     self.check(res, self.gclient(['cleanup']))
     self.check(res, self.gclient(['diff']))
     self.check(res, self.gclient(['export', 'foo']))
     self.check(res, self.gclient(['pack']))
     self.check(res, self.gclient(['revert']))
     self.check(res, self.gclient(['revinfo']))
     self.check(res, self.gclient(['runhooks']))
     self.check(res, self.gclient(['status']))
     self.check(res, self.gclient(['sync']))
     self.check(res, self.gclient(['update']))
 
+  def testConfig(self):
+    p = join(self.root_dir, '.gclient')
+    def test(cmd, expected):
+      if os.path.exists(p):
+        os.remove(p)
+      results = self.gclient(cmd)
+      self.check(('', '', 0), results)
+      self.checkString(expected, open(p, 'rb').read())
+
+    test(['config', self.svn_base + 'trunk/src/'],
+         'solutions = [\n'
+         '  { "name"        : "src",\n'
+         '    "url"         : "svn://127.0.0.1/svn/trunk/src",\n'
+         '    "custom_deps" : {\n'
+         '    },\n'
+         '    "safesync_url": ""\n'
+         '  },\n]\n')
+
+    test(['config', self.git_base + 'repo_1', '--name', 'src'],
+         'solutions = [\n'
+         '  { "name"        : "src",\n'
+         '    "url"         : "git://127.0.0.1/git/repo_1",\n'
+         '    "custom_deps" : {\n'
+         '    },\n'
+         '    "safesync_url": ""\n'
+         '  },\n]\n')
+
+    test(['config', 'foo', 'faa'],
+         'solutions = [\n'
+         '  { "name"        : "foo",\n'
+         '    "url"         : "foo",\n'
+         '    "custom_deps" : {\n'
+         '    },\n'
+         '    "safesync_url": "faa"\n'
+         '  },\n]\n')
+
+    test(['config', '--spec', '["blah blah"]'], '["blah blah"]')
+
+    os.remove(p)
+    results = self.gclient(['config', 'foo', 'faa', 'fuu'])
+    err = ('Usage: gclient.py config [options] [url] [safesync url]\n\n'
+           'gclient.py: error: Inconsistent arguments. Use either --spec or one'
+           ' or 2 args\n')
+    self.check(('', err, 2), results)
+    self.assertFalse(os.path.exists(join(self.root_dir, '.gclient')))
+
 
 class GClientSmokeSVN(GClientSmokeBase):
-  """sync is the most important command. Hence test it more."""
   def testSync(self):
+    # TODO(maruel): safesync, multiple solutions, invalid@revisions,
+    # multiple revisions.
     self.gclient(['config', self.svn_base + 'trunk/src/'])
     # Test unversioned checkout.
     results = self.gclient(['sync', '--deps', 'mac'])
     logging.debug(results[0])
     out = results[0].splitlines(False)
     self.assertEquals(17, len(out))
     self.checkString('', results[1])
     self.assertEquals(0, results[2])
     tree = mangle_svn_tree(
         (join('trunk', 'src'), 'src', FAKE.svn_revs[-1]),
@@ skipping 126 matching lines @@
     results = self.gclient(['revinfo'])
     out = ('src: %(base)s/src@2;\n'
            'src/other: %(base)s/other@2;\n'
            'src/third_party/foo: %(base)s/third_party/foo@1\n' %
           { 'base': self.svn_base + 'trunk' })
     self.check((out, '', 0), results)
 
 
 class GClientSmokeGIT(GClientSmokeBase):
   def testSync(self):
+    # TODO(maruel): safesync, multiple solutions, invalid@revisions,
+    # multiple revisions.
     self.gclient(['config', self.git_base + 'repo_1', '--name', 'src'])
     # Test unversioned checkout.
     results = self.gclient(['sync', '--deps', 'mac'])
     out = results[0].splitlines(False)
     # TODO(maruel): http://crosbug.com/3582 hooks run even if not matching, must
     # add sync parsing to get the list of updated files.
     self.assertEquals(13, len(out))
     self.assertTrue(results[1].startswith('Switched to a new branch \''))
     self.assertEquals(0, results[2])
     tree = mangle_git_tree(
@@ skipping 93 matching lines @@
       r'open\(\'src/hooked1\', \'w\'\)\.write\(\'hooked1\'\)\' in \'.*',
     out[1]))
     self.assertEquals(out[2], '')
     # runhooks runs all hooks even if not matching by design.
     self.assertTrue(re.match(r'^________ running \'.*?python -c '
       r'open\(\'src/hooked2\', \'w\'\)\.write\(\'hooked2\'\)\' in \'.*',
       out[3]))
     self.checkString('', results[1])
     self.assertEquals(0, results[2])
 
+  def testRevInfo(self):
+    # TODO(maruel): Test multiple solutions.
+    self.gclient(['config', self.git_base + 'repo_1', '--name', 'src'])
+    self.gclient(['sync', '--deps', 'mac'])
+    results = self.gclient(['revinfo'])
+    out = ('src: %(base)srepo_1@%(hash1)s;\n'
+           'src/repo2: %(base)srepo_2@%(hash2)s;\n'
+           'src/repo2/repo_renamed: %(base)srepo_3@%(hash3)s\n' %
+          {
+            'base': self.git_base,
+            'hash1': FAKE.git_hashes['repo_1'][1][0],
+            'hash2': FAKE.git_hashes['repo_2'][0][0],
+            'hash3': FAKE.git_hashes['repo_3'][1][0],
+          })
+    self.check((out, '', 0), results)
+
 
 if __name__ == '__main__':
   if '-v' in sys.argv:
     logging.basicConfig(level=logging.DEBUG)
   if '-l' in sys.argv:
     SHOULD_LEAK = True
     sys.argv.remove('-l')
   FAKE = FakeRepos(TRIAL_DIR, SHOULD_LEAK, True)
   try:
     FAKE.setUp()
     unittest.main()
   finally:
     FAKE.tearDown()