Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2283003: Make stateful_update use ping_omaha's flags. small devserver clenaups. (Closed)

Created:
10 years, 6 months ago by seano
Modified:
9 years, 7 months ago
Reviewers:
adlr, sosa
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//chromeos
Visibility:
Public.

Description

Make stateful_update use ping_omaha's flags. small devserver cleanups. TEST=Tested this by running it locally on my workstation and calling both stateful_update and memento_updater on a ToT build of chromiumOS on an eee1008HA.

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix sosa's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M src/platform/dev/autoupdate.py View 1 4 chunks +10 lines, -5 lines 0 comments Download
M src/platform/dev/stateful_update View 2 chunks +7 lines, -2 lines 0 comments Download
M src/scripts/start_devserver View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
seano
10 years, 6 months ago (2010-05-27 00:38:12 UTC) #1
adlr
LGTM
10 years, 6 months ago (2010-05-27 14:55:40 UTC) #2
sosa
Can you add a stanza about how you tested this in the codereview information ...
10 years, 6 months ago (2010-05-27 16:30:48 UTC) #3
seano
PTAL. http://codereview.chromium.org/2283003/diff/1/2 File src/platform/dev/autoupdate.py (right): http://codereview.chromium.org/2283003/diff/1/2#newcode108 src/platform/dev/autoupdate.py:108: if os.path.exists(image) and os.path.exists(unpacker): On 2010/05/27 16:30:48, sosa ...
10 years, 6 months ago (2010-05-27 23:52:02 UTC) #4
sosa
10 years, 6 months ago (2010-05-28 00:05:32 UTC) #5
lgtm, thnx

Powered by Google App Engine
This is Rietveld 408576698