Adds support for running coverity on Linux. Removes embedded password...

Adds support for running coverity on Linux. Removes embedded password
in favor of it being stashed in a seperate file. Exposes most of the
tune-ables as command line switches.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48453

[wtc, 2010-05-27 17:54:47]

LGTM.  Thanks!

http://codereview.chromium.org/2282006/diff/1/2
File tools/coverity/coverity.py (right):

http://codereview.chromium.org/2282006/diff/1/2#newcode137
tools/coverity/coverity.py:137: cmd = 'rm -rf %s/src/out/%s' %
(options.source_dir, options.target)
If Python has a function that removes a directory recursively, you can
use that instead of the platform-specific commands.

http://codereview.chromium.org/2282006/diff/1/2#newcode205
tools/coverity/coverity.py:205: option_parser.add_option('', '--dry-run',
action='store_true', default=False,
Nit: please add a blank line before the two original option_parser.add_option
calls for consistency.

http://codereview.chromium.org/2282006/diff/1/2#newcode215
tools/coverity/coverity.py:215: option_parser.add_option('', '--solution-file',
dest='solution_file',
Nit: some of these options' help messages are simply 'e.g. %s', which aren't
that helpful, not to mention the Windows pathname examples would be
confusing on Linux and Mac.

http://codereview.chromium.org/2282006/diff/1/2#newcode244
tools/coverity/coverity.py:244: option_parser.add_option('', '--coverity-port',
dest='coverity_port',
Nit: this should be --coverity-dbport for consistency with --coverity-dbhost.
I'd add an extra dash: --coverity-db-host and --coverity-db-port.

[jimhebert, 2010-05-27 18:55:46]

Re-submitted as described below.  I am not a committer so please commit if
it looks good.

On Thu, May 27, 2010 at 10:54 AM, <wtc@chromium.org> wrote:

> LGTM.  Thanks!
>
>
> http://codereview.chromium.org/2282006/diff/1/2#newcode137
> tools/coverity/coverity.py:137: cmd = 'rm -rf %s/src/out/%s' %
> (options.source_dir, options.target)
> If Python has a function that removes a directory recursively, you can
> use that instead of the platform-specific commands.
>

Done.  I was trying to be risk-averse and not touch the working windows
codepath (relying on rmdir /s /q), but, I agree with the need to fix that at
some point.  Might as well be now.


>
> http://codereview.chromium.org/2282006/diff/1/2#newcode205
> tools/coverity/coverity.py:205: option_parser.add_option('',
> '--dry-run', action='store_true', default=False,
> Nit: please add a blank line before the two original
> option_parser.add_option
> calls for consistency.
>

Done


>
> http://codereview.chromium.org/2282006/diff/1/2#newcode215
> tools/coverity/coverity.py:215: option_parser.add_option('',
> '--solution-file', dest='solution_file',
> Nit: some of these options' help messages are simply 'e.g. %s', which
> aren't
> that helpful, not to mention the Windows pathname examples would be
> confusing on Linux and Mac.
>

Done


>
> http://codereview.chromium.org/2282006/diff/1/2#newcode244
> tools/coverity/coverity.py:244: option_parser.add_option('',
> '--coverity-port', dest='coverity_port',
> Nit: this should be --coverity-dbport for consistency with
> --coverity-dbhost.
> I'd add an extra dash: --coverity-db-host and --coverity-db-port.


Done