Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2282003: Implement OS::ReleaseStore for Solaris (Closed)

Created:
10 years, 7 months ago by ry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement OS::ReleaseStore for Solaris Committed: http://code.google.com/p/v8/source/detail?r=4736

Patch Set 1 #

Patch Set 2 : FreeBSD too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/platform-freebsd.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ry
r4706 broke the Solaris build due to the new OS::ReleaseStore function. This fixes it.
10 years, 7 months ago (2010-05-27 00:57:24 UTC) #1
ry
I tested and added a patch for FreeBSD as well.
10 years, 7 months ago (2010-05-27 01:46:41 UTC) #2
Søren Thygesen Gjesse
LGTM
10 years, 7 months ago (2010-05-27 06:36:33 UTC) #3
Søren Thygesen Gjesse
10 years, 7 months ago (2010-05-27 06:40:17 UTC) #4
On 2010/05/27 06:36:33, Søren Gjesse wrote:
> LGTM

Thank you for the patch. Committed as r4736.

Powered by Google App Engine
This is Rietveld 408576698