Various refactorings in interceptor calling and loading.

Various refactorings in interceptor calling and loading.

1) do not push receiver early---that simplifies tail call preparation
on ia32/x64 and renders special cleanup unnecessary;
2) do not do second map check if interceptor's and cached holder
are the same;
3) do not push/pop receiver if receiver and holder registers are the same
(means that receiver is interceptor's holder);
4) do batch pushes on arm;
5) minor cosmetic improvements.

Committed: http://code.google.com/p/v8/source/detail?r=4732

[antonm, 2010-05-26 12:51:15]

Søren,

may you have a look?

[Søren Thygesen Gjesse, 2010-05-26 13:27:49]

LGTM

http://codereview.chromium.org/2282001/diff/2001/3002
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/2282001/diff/2001/3002#newcode392
src/ia32/stub-cache-ia32.cc:392: 
Maybe outlining the stack here could be good.

http://codereview.chromium.org/2282001/diff/2001/3002#newcode395
src/ia32/stub-cache-ia32.cc:395: // of this method.)
There are assumptions that CompileCallLoadPropertyWithInterceptor does not
clobber receiver.

[antonm, 2010-05-26 13:45:48]

All comments are updated as discussed on IM.

Thanks a lot for review, submitting.