Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 2279005: Move assertions to not take case to check that it's safe to omit CheckPrototypes in this case. (Closed)
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 782
783 // Interceptor returned nothing for this property. Try to use cached 783 // Interceptor returned nothing for this property. Try to use cached
784 // constant function. 784 // constant function.
785 785
786 // Check that the maps from interceptor's holder to constant function's 786 // Check that the maps from interceptor's holder to constant function's
787 // holder haven't changed and thus we can use cached constant function. 787 // holder haven't changed and thus we can use cached constant function.
788 if (interceptor_holder != lookup->holder()) { 788 if (interceptor_holder != lookup->holder()) {
789 stub_compiler_->CheckPrototypes(interceptor_holder, receiver, 789 stub_compiler_->CheckPrototypes(interceptor_holder, receiver,
790 lookup->holder(), scratch1, 790 lookup->holder(), scratch1,
791 scratch2, name, depth2, miss); 791 scratch2, name, depth2, miss);
792 } else {
792 // CheckPrototypes has a side effect of fetching a 'holder' 793 // CheckPrototypes has a side effect of fetching a 'holder'
793 // for API (object which is instanceof for the signature). It's 794 // for API (object which is instanceof for the signature). It's
794 // safe to omit it here, as if present, it should be fetched 795 // safe to omit it here, as if present, it should be fetched
795 // by the previous CheckPrototypes. 796 // by the previous CheckPrototypes.
796 ASSERT((depth2 == kInvalidProtoDepth) || (depth1 != kInvalidProtoDepth)); 797 ASSERT(depth2 == kInvalidProtoDepth);
797 } 798 }
798 799
799 // Invoke function. 800 // Invoke function.
800 if (can_do_fast_api_call) { 801 if (can_do_fast_api_call) {
801 GenerateFastApiCall(masm, optimization, arguments_.immediate()); 802 GenerateFastApiCall(masm, optimization, arguments_.immediate());
802 } else { 803 } else {
803 __ InvokeFunction(optimization.constant_function(), arguments_, 804 __ InvokeFunction(optimization.constant_function(), arguments_,
804 JUMP_FUNCTION); 805 JUMP_FUNCTION);
805 } 806 }
806 807
(...skipping 1384 matching lines...) Expand 10 before | Expand all | Expand 10 after
2191 // Return the generated code. 2192 // Return the generated code.
2192 return GetCode(); 2193 return GetCode();
2193 } 2194 }
2194 2195
2195 2196
2196 #undef __ 2197 #undef __
2197 2198
2198 } } // namespace v8::internal 2199 } } // namespace v8::internal
2199 2200
2200 #endif // V8_TARGET_ARCH_ARM 2201 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698