Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2270005: Make intercepted properties retrievable only by getter to be not enumerable. (Closed)

Created:
10 years, 7 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make intercepted properties retrievable only by getter to be not enumerable. Currently if there is no query callback, V8 finds out intercepted properties' attributes using getter: if getter returns not empty handle V8 treats such a property as property with NONE attribues which means this property is enumerable. However, if there is no enumerator, this property cannot be enumerated. Thus I think we should treat such properties as not enumerable. Drawback of this approach is now one has to implement both query and enumerator callbacks to implement enumerable intercepted properties. BUG=725 Committed: http://code.google.com/p/v8/source/detail?r=4751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Guys, may you have a look?
10 years, 7 months ago (2010-05-27 18:52:55 UTC) #1
Mads Ager (chromium)
10 years, 7 months ago (2010-05-27 19:24:28 UTC) #2
I think this makes sense. LGTM.

We should have a look at the V8 WebKit bindings and make sure that property
enumerator and query callbacks are always both defined and that they agree.

Powered by Google App Engine
This is Rietveld 408576698