Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2269003: Add more safeguards to image_to_usb.sh. List USB drives if --to is omitted (Closed)

Created:
10 years, 7 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
davidjames, rtc
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/chromiumos
Visibility:
Public.

Description

Add a few more safeguards to image_to_usb.sh so we don't accidentally overwrite a hard drive. Also without the --to option, list USB drives I've updated the CL to remove the space in the "] ;". I'm not sure I understand your "size != 0" comment as if the device is just attached for charging, it won't go through the trouble of becoming a USB storage device. Will chat in person.

Patch Set 1 : Stop manufacturer search at /sys #

Total comments: 1

Patch Set 2 : Clean up style consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M src/platform/installer/chromeos-common.sh View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/scripts/image_to_usb.sh View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Stewart
10 years, 7 months ago (2010-05-26 21:49:24 UTC) #1
davidjames
LGTM w/nits http://codereview.chromium.org/2269003/diff/2001/3001 File src/platform/installer/chromeos-common.sh (right): http://codereview.chromium.org/2269003/diff/2001/3001#newcode518 src/platform/installer/chromeos-common.sh:518: [ "$(cat ${sd}/removable)" = 1 ] ; ...
10 years, 7 months ago (2010-05-27 22:04:18 UTC) #2
Paul Stewart
10 years, 7 months ago (2010-05-27 22:52:37 UTC) #3
Fixed style.

Powered by Google App Engine
This is Rietveld 408576698